D13876: Display more readable tooltip text in summary page
Martin Tobias Holmedahl Sandsmark
noreply at phabricator.kde.org
Mon Jul 16 12:14:29 BST 2018
sandsmark requested changes to this revision.
sandsmark added a comment.
This revision now requires changes to proceed.
please fix what harald pointed out, otherwise it looks good.
INLINE COMMENTS
> sitter wrote in widgetEvents.cpp:158
> I would, for all strings, find them easier to read if they were
>
> QString("%1\n%2: %3).arg(foo, bar, kitten)
>
> instead of concatenations. It would also be easier to spot spacing problems when written that way.
>
> @sandsmark might disagree though ^^
doesn't matter much to me, I don't really disagree in this case. might make sense to make it translatable, I'm not sure if the way this is structured works in all languages.
REPOSITORY
R352 Filelight
REVISION DETAIL
https://phabricator.kde.org/D13876
To: andrewc, sandsmark, sitter
Cc: kde-utils-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20180716/cb8e20e5/attachment.html>
More information about the Kde-utils-devel
mailing list