D5101: Fix libzip cmake module

Rolf Eike Beer noreply at phabricator.kde.org
Sat Mar 18 16:45:12 UTC 2017


dakon added inline comments.

INLINE COMMENTS

> elvisangelaccio wrote in FindLibZip.cmake:35
> It's required but yes, is missing here. It's currently set in the `LibZip_INCLUDE_CONF_DIRS` variable which we use later in the cmakelists file of the plugin:
> 
>   include_directories(${LibZip_INCLUDE_DIRS} ${LibZip_INCLUDE_CONF_DIRS})
> 
> Do you think it would be better to have a single include variable with both paths?

Yes, put both into *_DIRS, list *_DIR here, and mark_as_advanced() them.

REPOSITORY
  R36 Ark

REVISION DETAIL
  https://phabricator.kde.org/D5101

To: elvisangelaccio, rthomsen
Cc: dakon, kde-utils-devel, #ark, tctara
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20170318/c90c1499/attachment.html>


More information about the Kde-utils-devel mailing list