D5101: Fix libzip cmake module

[Rolf Eike Beer]

dakon added a comment.


  Why does this break the dependency freeze? Because it introduces an optional dependency on pkg-config?

INLINE COMMENTS

> FindLibZip.cmake:20
>    NAMES zip.h
>    PATHS ${GNUDIR}/include
>  )

Shouldn't there be some PC_* hint here too?

It violates the CMake standards anyway: those variables that are searched are *_DIR, and *_DIRS are variables that are just set, in this case probably containing both this and LibZip_INCLUDE_CONF_DIRS.

> FindLibZip.cmake:35
>                                    FOUND_VAR LibZip_FOUND
>                                    REQUIRED_VARS LibZip_LIBRARIES LibZip_INCLUDE_DIRS
> +                                  VERSION_VAR LibZip_VERSION

The second include dir is missing here, or is it really optional?

REPOSITORY
  R36 Ark

REVISION DETAIL
  https://phabricator.kde.org/D5101

To: elvisangelaccio, rthomsen
Cc: dakon, kde-utils-devel, #ark, tctara
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20170318/f09ac4c6/attachment.html>