Review Request 128042: Don't shut down the current view after saving the preferences

Arno Möller arno at disconnect.de
Sat Jan 21 00:32:37 UTC 2017


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128042/
-----------------------------------------------------------

(Updated Jan. 21, 2017, 12:32 a.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Utils and Urs Wolfer.


Repository: krdc


Description
-------

No need to close the current view after saving preferences for the host.
It's actually harmful. MainWindow::saveHostPrefs() is called after app.exec(), closing the current view.


Diffs
-----

  mainwindow.cpp dd1d8a0 

Diff: https://git.reviewboard.kde.org/r/128042/diff/


Testing
-------

$ krdc rdp://<your.favorite.host>


Thanks,

Arno Möller

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20170121/3cc21e75/attachment.html>


More information about the Kde-utils-devel mailing list