Review Request 128042: Don't shut down the current view after saving the preferences

[Albert Astals Cid]

> On May 29, 2016, 10:53 a.m., Urs Wolfer wrote:
> > Thanks a lot! Can you please commit this to the latest stable branch?
> 
> Arno Möller wrote:
>     I don't have commit access, AFAIK (if you mean me).
> 
> Urs Wolfer wrote:
>     Ah, ok. I will take care of it (but it can take some days until I get to it...).
> 
> Arno Möller wrote:
>     take your time...

Seems this was applied, or at leat the code doesn't seem to be there anymore, closing.


- Albert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128042/#review95975
-----------------------------------------------------------


On May 29, 2016, 10:50 a.m., Arno Möller wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128042/
> -----------------------------------------------------------
> 
> (Updated May 29, 2016, 10:50 a.m.)
> 
> 
> Review request for KDE Utils and Urs Wolfer.
> 
> 
> Repository: krdc
> 
> 
> Description
> -------
> 
> No need to close the current view after saving preferences for the host.
> It's actually harmful. MainWindow::saveHostPrefs() is called after app.exec(), closing the current view.
> 
> 
> Diffs
> -----
> 
>   mainwindow.cpp dd1d8a0 
> 
> Diff: https://git.reviewboard.kde.org/r/128042/diff/
> 
> 
> Testing
> -------
> 
> $ krdc rdp://<your.favorite.host>
> 
> 
> Thanks,
> 
> Arno Möller
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20170121/bfb43f8e/attachment.html>