Review Request 129939: Fix kteatime

Martin Tobias Holmedahl Sandsmark martin.sandsmark at kde.org
Sun Feb 26 10:30:19 UTC 2017


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129939/
-----------------------------------------------------------

(Updated Feb. 26, 2017, 10:30 a.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Utils and Laurent Montel.


Changes
-------

Submitted with commit 453d4e2d1ca40575fd6cee0a5bfd7ac7e30ba3ba by Martin T. H. Sandsmark to branch master.


Bugs: 318086, 318087 and 375089
    http://bugs.kde.org/show_bug.cgi?id=318086
    http://bugs.kde.org/show_bug.cgi?id=318087
    http://bugs.kde.org/show_bug.cgi?id=375089


Repository: kteatime


Description
-------

Fixes several issues:

 * Popup notification not showing up when tea is done. This is the biggest issue, it is pretty useless without it.
 * Fix popup positioning when clicking, not it shows up in the right place right above the icon.
 * Fix tooltip.
 * Fix overlay icon when visualization is turned off.


Diffs
-----

  src/toplevel.h 98b7f70 
  src/toplevel.cpp 80d7167 

Diff: https://git.reviewboard.kde.org/r/129939/diff/


Testing
-------

Now it works.


Thanks,

Martin Tobias Holmedahl Sandsmark

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20170226/88f35231/attachment.html>


More information about the Kde-utils-devel mailing list