Review Request 129939: Fix kteatime

[Laurent Montel]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129939/#review102506
-----------------------------------------------------------


Ship it!




Seems ok for me
ship it

- Laurent Montel


On Feb. 11, 2017, 4:02 p.m., Martin Tobias Holmedahl Sandsmark wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129939/
> -----------------------------------------------------------
> 
> (Updated Feb. 11, 2017, 4:02 p.m.)
> 
> 
> Review request for KDE Utils and Laurent Montel.
> 
> 
> Bugs: 318086, 318087 and 375089
>     http://bugs.kde.org/show_bug.cgi?id=318086
>     http://bugs.kde.org/show_bug.cgi?id=318087
>     http://bugs.kde.org/show_bug.cgi?id=375089
> 
> 
> Repository: kteatime
> 
> 
> Description
> -------
> 
> Fixes several issues:
> 
>  * Popup notification not showing up when tea is done. This is the biggest issue, it is pretty useless without it.
>  * Fix popup positioning when clicking, not it shows up in the right place right above the icon.
>  * Fix tooltip.
>  * Fix overlay icon when visualization is turned off.
> 
> 
> Diffs
> -----
> 
>   src/toplevel.h 98b7f70 
>   src/toplevel.cpp 80d7167 
> 
> Diff: https://git.reviewboard.kde.org/r/129939/diff/
> 
> 
> Testing
> -------
> 
> Now it works.
> 
> 
> Thanks,
> 
> Martin Tobias Holmedahl Sandsmark
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20170212/d0471ff1/attachment-0001.html>