[Differential] [Requested Changes To] D4407: support loading qtlogging.ini from QLibraryInfo::DataPath too
Laurent Montel
noreply at phabricator.kde.org
Fri Feb 3 08:57:49 UTC 2017
mlaurent requested changes to this revision.
mlaurent added a comment.
This revision now requires changes to proceed.
nope it's incorrect.
You call twice readCategoriesFiles, you will duplicate list of categories.
So you need to choose QDir(QLibraryInfo::location(QLibraryInfo::DataPath)).absoluteFilePath(QStringLiteral("qtlogging.ini")); or QStandardPaths::locate(QStandardPaths::GenericConfigLocation, QStringLiteral("QtProject/qtlogging.ini")); but not twice.
We need to see if envPath is empty and load dataPath and not loading this two files.
REPOSITORY
R355 KDebugSettings
REVISION DETAIL
https://phabricator.kde.org/D4407
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: rdieter, mlaurent
Cc: kde-utils-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20170203/711b12a1/attachment.html>
More information about the Kde-utils-devel
mailing list