<table><tr><td style="">mlaurent requested changes to this revision.<br />mlaurent added a comment.<br />This revision now requires changes to proceed.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D4407" rel="noreferrer">View Revision</a></tr></table><br /><div><div><p>nope it's incorrect.<br />
You call twice readCategoriesFiles, you will duplicate list of categories.<br />
So you need to choose QDir(QLibraryInfo::location(QLibraryInfo::DataPath)).absoluteFilePath(QStringLiteral("qtlogging.ini")); or QStandardPaths::locate(QStandardPaths::GenericConfigLocation, QStringLiteral("QtProject/qtlogging.ini")); but not twice.</p>

<p>We need to see if envPath is empty and load dataPath and not loading this two files.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R355 KDebugSettings</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D4407" rel="noreferrer">https://phabricator.kde.org/D4407</a></div></div><br /><div><strong>EMAIL PREFERENCES</strong><div><a href="https://phabricator.kde.org/settings/panel/emailpreferences/" rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br /><div><strong>To: </strong>rdieter, mlaurent<br /><strong>Cc: </strong>kde-utils-devel<br /></div>