[Differential] [Request, 87 lines] D3142: Improve error handling for CliPlugins

[rthomsen (Ragnar Thomsen)]

rthomsen created this revision.
rthomsen added a reviewer: elvisangelaccio.
rthomsen set the repository for this revision to rARK Ark.
rthomsen added a project: Ark.
Restricted Application added a subscriber: kde-utils-devel.

REVISION SUMMARY
  This diff changes `ExtractionFailedPatterns` from a `QStringList` to a `QHash<QString,QVariant>`. This way we show custom error messages to the user by passing an error message associated with the `QRegularExpression` to `CliInterface`.
  
  A new pattern `ListFailedPatterns` was added which is used for `ListJob`, before it just used `ExtractionFailedPatterns`.

TEST PLAN
  Test listing or extracting archives handled by CliPlugins with some error.
  
  - Multi-volume archives with a missing volume.
  - Open Zip archive using Xz compression with clizip.

REPOSITORY
  rARK Ark

REVISION DETAIL
  https://phabricator.kde.org/D3142

AFFECTED FILES
  kerfuffle/cliinterface.cpp
  kerfuffle/cliinterface.h
  plugins/cli7zplugin/cliplugin.cpp
  plugins/clirarplugin/cliplugin.cpp
  plugins/cliunarchiverplugin/cliplugin.cpp
  plugins/clizipplugin/cliplugin.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: rthomsen, elvisangelaccio
Cc: kde-utils-devel, tctara
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20161023/aabf5b55/attachment.html>