[Differential] [Requested Changes To] D2993: Detect error when unrar version is too old

[elvisangelaccio (Elvis Angelaccio)]

elvisangelaccio requested changes to this revision.
elvisangelaccio added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> clirartest.cpp:223
> +        QCOMPARE(signalSpyError.count(), 1);
> +        QCOMPARE(signalSpyError.at(0).at(0).value<QString>(), errorMessage);
> +        return;

Use `.toString()` instead of `value<QString>()`, according to clazy the latter generates more code because there is a template instantiation

> cliplugin.cpp:316
> +                            m_unrarVersion));
> +            //killProcess();
> +            return false;

Please remove this commented line

> cliplugin.cpp:324
> +                            m_unrarVersion));
> +            //killProcess();
> +            return false;

here too

REPOSITORY
  rARK Ark

REVISION DETAIL
  https://phabricator.kde.org/D2993

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: rthomsen, elvisangelaccio
Cc: kde-utils-devel, tctara
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20161009/83e52a43/attachment.html>