[Differential] [Request, 136 lines] D2993: Detect error when unrar version is too old

[rthomsen (Ragnar Thomsen)]

rthomsen created this revision.
rthomsen added a reviewer: elvisangelaccio.
rthomsen set the repository for this revision to rARK Ark.
rthomsen added a project: Ark.
Restricted Application added a subscriber: kde-utils-devel.

REVISION SUMMARY
  Unrar 3 and 4 cannot open RAR5 archives. Currently, when opening a RAR5 archive with these old versions there is an uncaught error message which ends up in the comment widget.
  
  This diff adds a check for these error messages in clirar and emits an error signal with a proper message.
  
  CliInterface was changed so that `handleLine()` passes on the boolean return value of `readListLine()` to `readStdOut()`. This way, we can stop `readStdOut()` from handling further lines when `readListLine()` returns `false`. This was needed to avoid multiple error signals being emitted. Previously, the return value of `readListLine()` was unused.
  
  Unittests were added for both unrar 3 and 4.

TEST PLAN
  1. Install unrar v3 and v4.
  2. Open a RAR5 archive (these can be created with `-ma5` switch).
  3. Check that error messages are shown in the KMessageWidget and not in comment field.

REPOSITORY
  rARK Ark

REVISION DETAIL
  https://phabricator.kde.org/D2993

AFFECTED FILES
  autotests/plugins/clirarplugin/clirartest.cpp
  kerfuffle/cliinterface.cpp
  plugins/clirarplugin/cliplugin.cpp
  plugins/clirarplugin/cliplugin.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: rthomsen, elvisangelaccio
Cc: kde-utils-devel, tctara
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20161009/94fab58c/attachment.html>