Review Request 126139: Port KDiskFree to KF5 / Qt5.

[Rolf Eike Beer]

Am Sonntag, 27. März 2016, 08:00:30 schrieb Yoann Laissus:
> > On mars 26, 2016, 11:43 matin, Rolf Eike Beer wrote:
> > > This looks basically sane, but the diff is rather large (no wonder) and
> > > therefore hard to review. I would welcome if you could do some cleanups
> > > as separate commit before the porting. See the inline comments for what
> > > I would put into them. This should greatly reduce the number of lines
> > > in the porting diff and make it much easier to review.
> You should take a look at the branch I pushed here :
> https://quickgit.kde.org/?p=clones%2Fkdf%2Flaissus%2Fkdf-clone.git&a=shortlo
> g&h=c711a3a43d6ff379ac1196a71b2204f7aff8d05a
> 
> Everything have already been splitted in several commits, at least for the
> first three issues.
> 
> For the remaining two issues I'll fix them in the next few days (in their
> own separate commit, of course).

This looks sane, go for it.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20160327/cd6520a3/attachment.sig>