Review Request 126139: Port KDiskFree to KF5 / Qt5.

[Yoann Laissus]

> On mars 26, 2016, 11:43 matin, Rolf Eike Beer wrote:
> > This looks basically sane, but the diff is rather large (no wonder) and therefore hard to review. I would welcome if you could do some cleanups as separate commit before the porting. See the inline comments for what I would put into them. This should greatly reduce the number of lines in the porting diff and make it much easier to review.

You should take a look at the branch I pushed here : 
https://quickgit.kde.org/?p=clones%2Fkdf%2Flaissus%2Fkdf-clone.git&a=shortlog&h=c711a3a43d6ff379ac1196a71b2204f7aff8d05a

Everything have already been splitted in several commits, at least for the first three issues.

For the remaining two issues I'll fix them in the next few days (in their own separate commit, of course).

Thanks for your review !


- Yoann


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126139/#review94020
-----------------------------------------------------------


On mars 25, 2016, 7:28 matin, Yoann Laissus wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126139/
> -----------------------------------------------------------
> 
> (Updated mars 25, 2016, 7:28 matin)
> 
> 
> Review request for KDE Utils.
> 
> 
> Repository: kdf
> 
> 
> Description
> -------
> 
> A port of KDiskFree to KF5 / Qt5, without KDE4LibsSupport.
> Please let me know if everything is right, especially about the KMenu / KDialog migration.
> 
> About the desktop files, are my changes corrects ? And what about the KCM one ?
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt ad591e70cbbb6d10fdf362f68bfa3764646ab662 
>   disklist.h 0c972eeebc1a669a8943811303477e573307dabf 
>   disklist.cpp 12e12353748bbc46db013b90b5292c0cfa8f6c2f 
>   disks.h e5de94e843683d38dfee5d74bf7873de15ec6d3a 
>   disks.cpp 83f9729021fd24e2a19d333f5ef1503d7760e684 
>   doc/app/CMakeLists.txt 44bb820a89ee24d2dcd0bdf825cb64f8f4cc831e 
>   doc/kcontrol/CMakeLists.txt b0face2673997aad2193ea716634b7bad0c426ac 
>   kcmdf.h 1efa465f6e8fd028dbd2f0a95128849c657ca417 
>   kcmdf.cpp 36c379ec499f92bb3e1e26c79fba96ef410a6dda 
>   kcmdf.desktop 5e17fcc7eeb5ab9f1cd4cb759c4ee86a31526080 
>   kconftest.cpp 05d09d372a09f72be8134c77f956919d24182c9c 
>   kdf.h 466a7e60a6f43c8f4339e0051ec4aa04f10dab59 
>   kdf.cpp c1f8aa64526623a60b37c65319c6e933d66d3e35 
>   kdf.desktop  
>   kdfconfig.h 8cad04a176cf1f083c61761487ea425d2881ad08 
>   kdfconfig.cpp f6fe25807d04db6b258f4ce0eb7f53e86adb522d 
>   kdfitemdelegate.h 1d5f25f1fd733b544966567ed8f211b3be048bca 
>   kdfitemdelegate.cpp 7c2eac559e7d64cfe13181cbd034b26a25133670 
>   kdfwidget.h d611a477253189cb9f785a81ac4ab56e53828574 
>   kdfwidget.cpp 9312365631e6e766e5700c57ec17b1064073ed67 
>   kwikdisk.desktop  
>   kwikdisk.h 39582d09f00bdaef3b0d61cc61f852cba0d8272c 
>   kwikdisk.cpp 713ebfc056c82a4101b736f46b4803e75db7e7e0 
>   mntconfig.h ecb07f19eeef5b398f2e366bb2792cda94c35f69 
>   mntconfig.cpp 33cd92a9b3325dca4d4b2038b904f9ee8d16e71f 
>   mntconfig.ui 39cb679a2dff3e47f8cb3a29a766c941e1fe3035 
>   optiondialog.h e08f1168dc89ff24fff17cdfe600ed3c655646cd 
>   optiondialog.cpp 97d5e3fb75351abeb184064cae3578bdb39822b1 
>   pics/CMakeLists.txt 7affd27ee45de94f71ab2af5cab74f1a54bb9400 
>   pics/hi128-app-kdf.png  
>   pics/hi128-app-kwikdisk.png  
>   pics/hi16-app-kdf.png  
>   pics/hi16-app-kwikdisk.png  
>   pics/hi22-app-kdf.png  
>   pics/hi22-app-kwikdisk.png  
>   pics/hi32-app-kdf.png  
>   pics/hi32-app-kwikdisk.png  
>   pics/hi48-app-kdf.png  
>   pics/hi48-app-kwikdisk.png  
>   pics/hi64-app-kdf.png  
>   pics/hi64-app-kwikdisk.png  
>   pics/ox16-app-kcmdf.png  
>   pics/ox22-app-kcmdf.png  
>   pics/ox32-app-kcmdf.png  
>   stdoption.h 78527c6db976993155307a0fcfa7998e07fd6892 
>   stdoption.cpp fce7b894164cf5e8a0fde80353661919a2d5d045 
> 
> Diff: https://git.reviewboard.kde.org/r/126139/diff/
> 
> 
> Testing
> -------
> 
> All features of KDiskFree tested.
> 
> 
> Thanks,
> 
> Yoann Laissus
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20160327/2b3062b5/attachment.html>