[Differential] [Accepted] D1167: Part: simplify openFile() and use more KMessageWidgets

rthomsen (Ragnar Thomsen) noreply at phabricator.kde.org
Fri Mar 18 07:13:06 UTC 2016


rthomsen accepted this revision.
rthomsen added a comment.
This revision is now accepted and ready to land.


  Code looks good. Tested and works for me. The text is a bit squeezed when there are two lines in the KMessageWidget, but I think it's ok.

INLINE COMMENTS
  part/part.cpp:525 I would rather have these warnings as errors (displayed with red background). Same with the others below.

REPOSITORY
  rARK Ark

BRANCH
  fix-overwrite

REVISION DETAIL
  https://phabricator.kde.org/D1167

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: elvisangelaccio, rthomsen
Cc: kde-utils-devel, tctara


More information about the Kde-utils-devel mailing list