[Differential] [Request, 106 lines] D1167: Part: simplify openFile() and use more KMessageWidgets

elvisangelaccio (Elvis Angelaccio) noreply at phabricator.kde.org
Thu Mar 17 22:55:41 UTC 2016


elvisangelaccio created this revision.
elvisangelaccio added a reviewer: rthomsen.
Herald added a subscriber: kde-utils-devel.
Herald added a project: Ark.

REVISION SUMMARY
  When the user opens (from Dolphin) an archive whose plugin is not available,
  the feedback is currently very annoying:
  
  - a KMessageBox pops up with the error message
  - the user closes the message box
  - an empty (and useless) Ark window shows up
  
  This patch replaces the KMessageBoxes with KMessageWidgets, so that the 3 steps
  above are merged into 1.
  
  Possible alternative solution: display only the KMessageBox, then quit Ark
  (preventing the MainWindow from showing up). But I'm not sure if this is
  actually better.
  
  This patch also move the input validation code from Part::openFile() to a new
  Part::isLocalFileValid() method.

REPOSITORY
  rARK Ark

BRANCH
  fix-overwrite

REVISION DETAIL
  https://phabricator.kde.org/D1167

AFFECTED FILES
  part/part.cpp
  part/part.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: elvisangelaccio, rthomsen
Cc: kde-utils-devel, tctara


More information about the Kde-utils-devel mailing list