Review Request 107634: Only require that archive name starts with subfolder name, not that they are identical

[Sandro Mani]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/107634/
-----------------------------------------------------------

(Updated March 11, 2016, 7:20 a.m.)


Status
------

This change has been discarded.


Review request for KDE Utils.


Repository: ark


Description
-------

Improve subfolder autodetection
Details:
- the path in RPM files begins with ./, which broke the m_isSingleFolderArchive detection (since top-level folder is always .)
- When autodetecting the subfolder, what one expects IMO is that it prevents situations like
<archivename>/<archivename>/{files}
when extracting the archive. However, if the archive contains only a single folder which is _not_ equal to the archive basename, in those cases a new folder <archivename> should be created. Otherwise, for instance when extracting an rpm file libfoo.rpm, the files would be extracted in usr (which is the only top-level folder in the archive), but it is far more intuitive to have the files extracted under libfoo/usr/{files}


Diffs
-----

  app/batchextract.cpp 9e466350568384247e99362745205c417b27873f 
  kerfuffle/archive.h 515788f978c1d29146c25dcb57a9dad2d46371f7 
  kerfuffle/archive.cpp c2c5b18528def63405a8703475b1c592ca945973 
  kerfuffle/jobs.cpp aedc62c4c9902c4f3207c648747f2e427446d5e5 

Diff: https://git.reviewboard.kde.org/r/107634/diff/


Testing
-------


Thanks,

Sandro Mani

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20160311/340dcb57/attachment.html>