<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/107634/">https://git.reviewboard.kde.org/r/107634/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been discarded.</h1>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Utils.</div>
<div>By Sandro Mani.</div>
<p style="color: grey;"><i>Updated March 11, 2016, 7:20 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
ark
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Improve subfolder autodetection
Details:
- the path in RPM files begins with ./, which broke the m_isSingleFolderArchive detection (since top-level folder is always .)
- When autodetecting the subfolder, what one expects IMO is that it prevents situations like
<archivename>/<archivename>/{files}
when extracting the archive. However, if the archive contains only a single folder which is _not_ equal to the archive basename, in those cases a new folder <archivename> should be created. Otherwise, for instance when extracting an rpm file libfoo.rpm, the files would be extracted in usr (which is the only top-level folder in the archive), but it is far more intuitive to have the files extracted under libfoo/usr/{files}</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>app/batchextract.cpp <span style="color: grey">(9e466350568384247e99362745205c417b27873f)</span></li>
<li>kerfuffle/archive.h <span style="color: grey">(515788f978c1d29146c25dcb57a9dad2d46371f7)</span></li>
<li>kerfuffle/archive.cpp <span style="color: grey">(c2c5b18528def63405a8703475b1c592ca945973)</span></li>
<li>kerfuffle/jobs.cpp <span style="color: grey">(aedc62c4c9902c4f3207c648747f2e427446d5e5)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/107634/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>