[Differential] [Updated, 462 lines] D1076: Add properties dialog

[rthomsen (Ragnar Thomsen)]

rthomsen updated this revision to Diff 2635.
rthomsen added a comment.


  Incorporate Elvis' suggestions.
  
  One question:
  Archive::isPasswordProtected() (which already existed before this patch) cannot be const due to calling listIfNotListed(). In documentation for Q_PROPERTY it is recommended that all READ functions be const. What's the reason for isPasswordProtected() calling listIfNotListed()? And is it safe that this functions is not const? Also, if this function calls listIfNotListed() should some of the other READ functions call listIfNotListed() as well?

REPOSITORY
  rARK Ark

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D1076?vs=2629&id=2635

REVISION DETAIL
  https://phabricator.kde.org/D1076

AFFECTED FILES
  app/arkui.rc
  kerfuffle/CMakeLists.txt
  kerfuffle/archive_kerfuffle.cpp
  kerfuffle/archive_kerfuffle.h
  kerfuffle/archiveinterface.h
  kerfuffle/propertiesdialog.cpp
  kerfuffle/propertiesdialog.h
  kerfuffle/propertiesdialog.ui
  part/ark_part.rc
  part/part.cpp
  part/part.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: rthomsen, elvisangelaccio
Cc: kde-utils-devel, tctara