[Differential] [Request, 712 lines] D1761: Port service menus to KFileItemAction
elvisangelaccio (Elvis Angelaccio)
noreply at phabricator.kde.org
Fri Jun 3 14:22:46 UTC 2016
elvisangelaccio created this revision.
elvisangelaccio added a reviewer: rthomsen.
Restricted Application added a subscriber: kde-utils-devel.
Restricted Application added a project: Ark.
REVISION SUMMARY
The Compress and Extract service menus shown in Dolphin's context menu are now
provided by two new KFileItemAction plugins. This allows us to do a lot of
useful checks before actually showing the actions in the context menu.
This also allows us to stop hardcoding the supported mimetypes for the Extract
menu. This is actually needed in order to support the Extract menu when more
than one archive is selected. In this case Dolphin sends to the plugin the
generic 'application/octet-stream' mimetype, so we have to manually check
anyway the mimetype of any given URL.
TEST PLAN
- Apply https://git.reviewboard.kde.org/r/128088/ to dolphin master
- Make sure that the Compress and Extract menu are disabled in read-only folders
- Make sure that Compress is not shown when right-clicking an archive
- Uninstall zip/7z and make sure that 'Compress -> as ZIP' is not shown
REPOSITORY
rARK Ark
BRANCH
kfileitemaction
REVISION DETAIL
https://phabricator.kde.org/D1761
AFFECTED FILES
app/CMakeLists.txt
app/ark_addtoservicemenu.desktop
app/ark_servicemenu.desktop.cmake
app/compressfileitemaction.cpp
app/compressfileitemaction.h
app/compressfileitemaction.json
app/extractfileitemaction.cpp
app/extractfileitemaction.h
app/extractfileitemaction.json
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: elvisangelaccio, rthomsen
Cc: kde-utils-devel, tctara
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20160603/5b805907/attachment.html>
More information about the Kde-utils-devel
mailing list