<table><tr><td style="">elvisangelaccio created this revision.<br />elvisangelaccio added a reviewer: rthomsen.<br />Restricted Application added a subscriber: kde-utils-devel.<br />Restricted Application added a project: Ark.</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D1761" rel="noreferrer">View Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>The Compress and Extract service menus shown in Dolphin's context menu are now<br />
provided by two new KFileItemAction plugins. This allows us to do a lot of<br />
useful checks before actually showing the actions in the context menu.</p>
<p>This also allows us to stop hardcoding the supported mimetypes for the Extract<br />
menu. This is actually needed in order to support the Extract menu when more<br />
than one archive is selected. In this case Dolphin sends to the plugin the<br />
generic 'application/octet-stream' mimetype, so we have to manually check<br />
anyway the mimetype of any given URL.</p></div></div><br /><div><strong>TEST PLAN</strong><div><ul class="remarkup-list">
<li class="remarkup-list-item">Apply <a href="https://git.reviewboard.kde.org/r/128088/" class="remarkup-link" target="_blank" rel="noreferrer">https://git.reviewboard.kde.org/r/128088/</a> to dolphin master</li>
<li class="remarkup-list-item">Make sure that the Compress and Extract menu are disabled in read-only folders</li>
<li class="remarkup-list-item">Make sure that Compress is not shown when right-clicking an archive</li>
<li class="remarkup-list-item">Uninstall zip/7z and make sure that 'Compress -> as ZIP' is not shown</li>
</ul></div></div><br /><div><strong>REPOSITORY</strong><div><div>rARK Ark</div></div></div><br /><div><strong>BRANCH</strong><div><div>kfileitemaction</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D1761" rel="noreferrer">https://phabricator.kde.org/D1761</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>app/CMakeLists.txt<br />
app/ark_addtoservicemenu.desktop<br />
app/ark_servicemenu.desktop.cmake<br />
app/compressfileitemaction.cpp<br />
app/compressfileitemaction.h<br />
app/compressfileitemaction.json<br />
app/extractfileitemaction.cpp<br />
app/extractfileitemaction.h<br />
app/extractfileitemaction.json</div></div></div><br /><div><strong>EMAIL PREFERENCES</strong><div><a href="https://phabricator.kde.org/settings/panel/emailpreferences/" rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br /><div><strong>To: </strong>elvisangelaccio, rthomsen<br /><strong>Cc: </strong>kde-utils-devel, tctara<br /></div>