Review Request 128060: Fix handling command line arguments

Arno Möller arno at disconnect.de
Fri Jul 22 04:24:35 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128060/
-----------------------------------------------------------

(Updated July 22, 2016, 4:24 a.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Utils and Urs Wolfer.


Repository: krdc


Description
-------

QUrl::fromLocalFile is clearly wrong. It gives us file://rdp:// or similar garbage.

We cannot use QUrl::fromUserInput() either, since this gives us an http:// or an ftp:// URL if the scheme is empty, depending on the hostname. Due to the plugin architecture we cannot assume
that krdc can't handle those protocols.
    
Assume that we're dealing with just a hostname instead, and further assume that the protocol is vnc:// (default since kde3).


Diffs
-----

  main.cpp 73093f3 

Diff: https://git.reviewboard.kde.org/r/128060/diff/


Testing
-------


Thanks,

Arno Möller

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20160722/3236d8ec/attachment-0001.html>


More information about the Kde-utils-devel mailing list