[Differential] [Requested Changes To] D2194: Implement support for multi-volume archives

[elvisangelaccio (Elvis Angelaccio)]

elvisangelaccio requested changes to this revision.
elvisangelaccio added a comment.
This revision now requires changes to proceed.


  Patch doesn't apply, can you rebase? :)

INLINE COMMENTS

> cli7ztest.cpp:308
>  
> -    QStringList replacedArgs = plugin->substituteAddVariables(addArgs, {}, password, encryptHeader, compressionLevel);
> +    QStringList replacedArgs = plugin->substituteAddVariables(addArgs, {}, password, encryptHeader, compressionLevel, 0);
>  

Can you add at least one test case in which we do set a volume number? Same with the rar test

> cliinterface.cpp:840
> +{
> +    if (volumeSize <= 0 || volumeSize > 1024000) {
> +        return QString();

What does 1024000 represent?

> compressionoptionswidget.cpp:66
> +        // Convert to kilobytes.
> +        opts[QStringLiteral("VolumeSize")] = QString::number(volumeSizeSpinbox->value() * 1024);
> +    }

We already compute this number in `volumeSize()`, so we can just call this function.

REPOSITORY
  rARK Ark

REVISION DETAIL
  https://phabricator.kde.org/D2194

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: rthomsen, elvisangelaccio
Cc: kde-utils-devel, tctara
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20160719/09981fbb/attachment.html>