<table><tr><td style="">elvisangelaccio requested changes to this revision.<br />elvisangelaccio added a comment.<br />This revision now requires changes to proceed.</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D2194" rel="noreferrer">View Revision</a></tr></table><br /><div><div><p>Patch doesn't apply, can you rebase? :)</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D2194#inline-8677" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">cli7ztest.cpp:308</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: #ffd0d0;">    <span class="n">QStringList</span> <span class="n">replacedArgs</span> <span style="color: #aa2211">=</span> <span class="n">plugin</span><span style="color: #aa2211">-></span><span class="n">substituteAddVariables</span><span class="p">(</span><span class="n">addArgs</span><span class="p">,</span> <span class="p">{},</span> <span class="n">password</span><span class="p">,</span> <span class="n">encryptHeader</span><span class="p">,</span> <span class="n">compressionLevel</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">    <span class="n">QStringList</span> <span class="n">replacedArgs</span> <span style="color: #aa2211">=</span> <span class="n">plugin</span><span style="color: #aa2211">-></span><span class="n">substituteAddVariables</span><span class="p">(</span><span class="n">addArgs</span><span class="p">,</span> <span class="p">{},</span> <span class="n">password</span><span class="p">,</span> <span class="n">encryptHeader</span><span class="p">,</span> <span class="n">compressionLevel<span class="bright"></span></span><span class="bright"></span><span class="p"><span class="bright">,</span></span><span class="bright"> </span><span style="color: #601200"><span class="bright">0</span></span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Can you add at least one test case in which we do set a volume number? Same with the rar test</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D2194#inline-8679" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">cliinterface.cpp:840</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;"><span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">    <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">volumeSize</span> <span style="color: #aa2211"><=</span> <span style="color: #601200">0</span> <span style="color: #aa2211">||</span> <span class="n">volumeSize</span> <span style="color: #aa2211">></span> <span style="color: #601200">1024000</span><span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">        <span style="color: #aa4000">return</span> <span class="n">QString</span><span class="p">();</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">What does 1024000 represent?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D2194#inline-8728" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">compressionoptionswidget.cpp:66</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">        <span style="color: #74777d">// Convert to kilobytes.</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">        <span class="n">opts</span><span class="p">[</span><span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"VolumeSize"</span><span class="p">)]</span> <span style="color: #aa2211">=</span> <span class="n">QString</span><span style="color: #aa2211">::</span><span class="n">number</span><span class="p">(</span><span class="n">volumeSizeSpinbox</span><span style="color: #aa2211">-></span><span class="n">value</span><span class="p">()</span> <span style="color: #aa2211">*</span> <span style="color: #601200">1024</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: #d0ffd0;">    <span class="p">}</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">We already compute this number in <tt style="background: #ebebeb; font-size: 13px;">volumeSize()</tt>, so we can just call this function.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>rARK Ark</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D2194" rel="noreferrer">https://phabricator.kde.org/D2194</a></div></div><br /><div><strong>EMAIL PREFERENCES</strong><div><a href="https://phabricator.kde.org/settings/panel/emailpreferences/" rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br /><div><strong>To: </strong>rthomsen, elvisangelaccio<br /><strong>Cc: </strong>kde-utils-devel, tctara<br /></div>