Review Request 128381: Remove ugly passive popup

[Martin Tobias Holmedahl Sandsmark]

> On July 5, 2016, 7 p.m., Laurent Montel wrote:
> > src/toplevel.cpp, line 116
> > <https://git.reviewboard.kde.org/r/128381/diff/1/?file=471135#file471135line116>
> >
> >     So you show all the time the showTimeEditDialog ?
> >     Are you sure that it's ok ?
> >     It will take the focus no ?

It might not be the best solution, but it is very convenient to be able to start a new tea just by clicking, and left clicking for selecting a pre-determined. If people just press cancel in the dialog that opens the countdown continous as normal, but if they select a new time it starts over from that.

But another option is to show the menu both when left and right clicking (which was suggested in a bug report), or just abandoning this patch completely.


- Martin Tobias Holmedahl


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128381/#review97134
-----------------------------------------------------------


On July 5, 2016, 5:32 p.m., Martin Tobias Holmedahl Sandsmark wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128381/
> -----------------------------------------------------------
> 
> (Updated July 5, 2016, 5:32 p.m.)
> 
> 
> Review request for KDE Utils and Laurent Montel.
> 
> 
> Repository: kteatime
> 
> 
> Description
> -------
> 
> The passive popup looks really out of place, and duplicates the functionality of the tooltip, so I suggest to just remove it.
> 
> 
> Diffs
> -----
> 
>   src/toplevel.h e3a4f6d 
>   src/toplevel.cpp 0c77b66 
> 
> Diff: https://git.reviewboard.kde.org/r/128381/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Tobias Holmedahl Sandsmark
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20160706/89fd9893/attachment-0001.html>