Review Request 128381: Remove ugly passive popup

Laurent Montel montel at kde.org
Tue Jul 5 19:00:43 UTC 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128381/#review97134
-----------------------------------------------------------




src/toplevel.cpp (line 115)
<https://git.reviewboard.kde.org/r/128381/#comment65622>

    So you show all the time the showTimeEditDialog ?
    Are you sure that it's ok ?
    It will take the focus no ?


- Laurent Montel


On July 5, 2016, 5:32 p.m., Martin Tobias Holmedahl Sandsmark wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128381/
> -----------------------------------------------------------
> 
> (Updated July 5, 2016, 5:32 p.m.)
> 
> 
> Review request for KDE Utils and Laurent Montel.
> 
> 
> Repository: kteatime
> 
> 
> Description
> -------
> 
> The passive popup looks really out of place, and duplicates the functionality of the tooltip, so I suggest to just remove it.
> 
> 
> Diffs
> -----
> 
>   src/toplevel.h e3a4f6d 
>   src/toplevel.cpp 0c77b66 
> 
> Diff: https://git.reviewboard.kde.org/r/128381/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Tobias Holmedahl Sandsmark
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20160705/3d3bbb8a/attachment.html>


More information about the Kde-utils-devel mailing list