[Differential] [Request, 88 lines] D3840: Bring back extraction of single-file archives without subfolders

[elvisangelaccio (Elvis Angelaccio)]

elvisangelaccio created this revision.
elvisangelaccio added a reviewer: rthomsen.
Restricted Application added a subscriber: kde-utils-devel.
Restricted Application added a project: Ark.

REVISION SUMMARY
  Single-file archives are not single-folder archive, yet we want to extract them
  without a destination subfolder (like it used to work in the past).
  
  This patch adds new methods `isSingleFile()` and `shouldExtractToSubfolder()`
  to Archive, the latter being used to choose whether to extract into a subfolder.
  
  CCBUG: 374253

TEST PLAN
  Extract single-folder and single-file archives with quick-extraction -> no
  subfolder gets created. Opening the extraction dialog results in the subfolder
  widget unchecked.
  
  The expanded loadtest passes.

REPOSITORY
  R36 Ark

BRANCH
  fix-single-file-archives

REVISION DETAIL
  https://phabricator.kde.org/D3840

AFFECTED FILES
  app/batchextract.cpp
  autotests/kerfuffle/data/singleemptyfolder.zip
  autotests/kerfuffle/loadtest.cpp
  kerfuffle/archive_kerfuffle.cpp
  kerfuffle/archive_kerfuffle.h
  kerfuffle/extractiondialog.cpp
  kerfuffle/extractiondialog.h
  part/part.cpp
  part/part.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: elvisangelaccio, rthomsen
Cc: kde-utils-devel, tctara
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20161228/f7f67804/attachment.html>