Review Request 128522: [KCharSelect] Add bookmarks support

[David Faure]

> On Aug. 19, 2016, 7:28 a.m., David Faure wrote:
> > The answer to question 1 is KBookmarkDialog, from the kbookmarks framework (and its method addBookmark).
> 
> Christoph Feck wrote:
>     But how can I modify the "Add Bookmark" menu item to use it?

Good question, seems a bit silly right now: it turns out there's a hidden config setting for that.

src/kbookmarkmanager.cpp:    s_self->m_advancedaddbookmark = cg.readEntry("AdvancedAddBookmarkDialog", false);

Feel free to add API to kbookmarkmanager to let apps choose, instead.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128522/#review98491
-----------------------------------------------------------


On Sept. 1, 2016, 4:30 p.m., Christoph Feck wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128522/
> -----------------------------------------------------------
> 
> (Updated Sept. 1, 2016, 4:30 p.m.)
> 
> 
> Review request for KDE Utils and David Faure.
> 
> 
> Bugs: 242333
>     http://bugs.kde.org/show_bug.cgi?id=242333
> 
> 
> Repository: kcharselect
> 
> 
> Description
> -------
> 
> Added a standard Bookmarks menu. The bookmarks are named U+xxxxx for the currently selected character.
> 
> Two issues:
> 
> 1. Is there a way to actually get an "Add Bookmark" dialog? The bookmarks are silently added.
> 
> 2. I blindly copied the "filename" stuff from other code I have seen. To me it looks like the bookmarks are then not editable, if the system already has a bookmarks file?
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 6db5c66 
>   kcharselectdia.h 27515a4 
>   kcharselectdia.cc 28d65f9 
>   kcharselectui.rc d8556ee 
> 
> Diff: https://git.reviewboard.kde.org/r/128522/diff/
> 
> 
> Testing
> -------
> 
> Tested with kwidgetsaddons from master.
> To test with older frameworks: "currentCodePoint()" -> "currentChar().unicode()"
> "setCurrentCodePoint(uc)" -> "setCurrentChar(QChar(uc))"
> 
> 
> Thanks,
> 
> Christoph Feck
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20161225/da1e4577/attachment.html>