[Differential] [Requested Changes To] D3742: Fix sorting

[elvisangelaccio (Elvis Angelaccio)]

elvisangelaccio requested changes to this revision.
elvisangelaccio added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> archivesortfiltermodel.cpp:34-46
> +    m_propertiesMap = {
> +        { FullPath, "fullPath" },
> +        { Size, "size" },
> +        { CompressedSize, "compressedSize" },
> +        { Permissions, "permissions" },
> +        { Owner, "owner" },
> +        { Group, "group" },

Add a getter in ArchiveModel for this map? So we don't have to keep it in sync if we change it

> archivesortfiltermodel.h:39
> +private:
> +    ArchiveModel *m_archiveModel;
> +    QMap<int, QByteArray> m_propertiesMap;

No need to store the model I think, using `sourceModel()` + qobject_cast should be enough

REPOSITORY
  R36 Ark

REVISION DETAIL
  https://phabricator.kde.org/D3742

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: rthomsen, elvisangelaccio
Cc: kde-utils-devel, tctara
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20161219/be899580/attachment-0001.html>