[Differential] [Updated] D3573: Implement search function

[elvisangelaccio (Elvis Angelaccio)]

elvisangelaccio added a comment.


  Let's also involve the VDG in the review, please add screenshots for them.
  
  Comments from my side:
  
  - A case-sensitive button like in Kate would be good, but can be done in the next iteration. Same for the green/red color that Kate uses for the search line edit.
  - Given that the line edit has the "Type to search..." hint (which is good, neither dolphin nor kate has it!), I think that the `Find:` label is redundant and can be dropped.
  - I never noticed that both Dolphin and Kate have the close button on the left of the search bar, I find it odd. What does the VDG think? Should we put the close button on the left or on the right?
  - I don't think the ESC key is a big deal, but if it's easy to replicate the Kate behavior then we could do it.

REPOSITORY
  R36 Ark

REVISION DETAIL
  https://phabricator.kde.org/D3573

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: rthomsen, elvisangelaccio
Cc: kde-utils-devel, tctara
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20161203/f0279900/attachment.html>