<table><tr><td style="">elvisangelaccio added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D3573" rel="noreferrer">View Revision</a></tr></table><br /><div><div><p>Let's also involve the VDG in the review, please add screenshots for them.</p>
<p>Comments from my side:</p>
<ul class="remarkup-list">
<li class="remarkup-list-item">A case-sensitive button like in Kate would be good, but can be done in the next iteration. Same for the green/red color that Kate uses for the search line edit.</li>
<li class="remarkup-list-item">Given that the line edit has the "Type to search..." hint (which is good, neither dolphin nor kate has it!), I think that the <tt style="background: #ebebeb; font-size: 13px;">Find:</tt> label is redundant and can be dropped.</li>
<li class="remarkup-list-item">I never noticed that both Dolphin and Kate have the close button on the left of the search bar, I find it odd. What does the VDG think? Should we put the close button on the left or on the right?</li>
<li class="remarkup-list-item">I don't think the ESC key is a big deal, but if it's easy to replicate the Kate behavior then we could do it.</li>
</ul></div></div><br /><div><strong>REPOSITORY</strong><div><div>R36 Ark</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D3573" rel="noreferrer">https://phabricator.kde.org/D3573</a></div></div><br /><div><strong>EMAIL PREFERENCES</strong><div><a href="https://phabricator.kde.org/settings/panel/emailpreferences/" rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br /><div><strong>To: </strong>rthomsen, elvisangelaccio<br /><strong>Cc: </strong>kde-utils-devel, tctara<br /></div>