[Differential] [Request, 255 lines] D1516: Add basic test functionality
rthomsen (Ragnar Thomsen)
noreply at phabricator.kde.org
Sat Apr 30 21:26:51 UTC 2016
rthomsen created this revision.
rthomsen added a reviewer: elvisangelaccio.
rthomsen set the repository for this revision to rARK Ark.
rthomsen added a project: Ark.
Restricted Application added a subscriber: kde-utils-devel.
REVISION SUMMARY
This diff adds a TestJob and associated action in Part. Test functionality is enabled in plugin json files, currently for clizip, clirar and cli7z. Test results are displayed simple as success/failure in a KMessageBox.
Testing password-protected archives will currently result in an errorbox, due to these archives potentially having different passwords for each file and hence multiple password prompts might pop up.
Bug 140492 <https://bugs.kde.org/show_bug.cgi?id=140492> (reported in 2007!!)
https://phabricator.kde.org/T966
TEST PLAN
- Open various types of supported archives and run the tests.
- The "Test" action should be disabled for libarchiveplugin.
- Autotests pass.
REPOSITORY
rARK Ark
REVISION DETAIL
https://phabricator.kde.org/D1516
AFFECTED FILES
autotests/kerfuffle/jsonarchiveinterface.cpp
autotests/kerfuffle/jsonarchiveinterface.h
kerfuffle/archive_kerfuffle.cpp
kerfuffle/archive_kerfuffle.h
kerfuffle/archiveformat.cpp
kerfuffle/archiveformat.h
kerfuffle/archiveinterface.h
kerfuffle/cliinterface.cpp
kerfuffle/cliinterface.h
kerfuffle/jobs.cpp
kerfuffle/jobs.h
part/ark_part.rc
part/part.cpp
part/part.h
plugins/cli7zplugin/cliplugin.cpp
plugins/cli7zplugin/kerfuffle_cli7z.json
plugins/clirarplugin/cliplugin.cpp
plugins/clirarplugin/kerfuffle_clirar.json
plugins/clizipplugin/cliplugin.cpp
plugins/clizipplugin/kerfuffle_clizip.json
plugins/libarchive/libarchiveplugin.cpp
plugins/libarchive/libarchiveplugin.h
plugins/libsinglefileplugin/singlefileplugin.cpp
plugins/libsinglefileplugin/singlefileplugin.h
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: rthomsen, elvisangelaccio
Cc: kde-utils-devel, tctara
More information about the Kde-utils-devel
mailing list