[Differential] [Request, 7 lines] D1428: add zip support in unarchiver plugin

acelankao (AceLan Kao) noreply at phabricator.kde.org
Sat Apr 16 02:02:46 UTC 2016


acelankao created this revision.
acelankao added a reviewer: Ark.
Restricted Application added a subscriber: kde-utils-devel.
Restricted Application added a project: Ark.

REVISION SUMMARY
  The Chinese filename in zip archive which compressed under win xp/win 7
  won't unarchive correctly by 7z nor zip command.
  It's an old bug[1] and still exists.
  Luckily unar can fix this issue perfectly, so add zip mimetype in unarchiver
  and increase its priority to handle zip archive.
  
  1. https://bugzilla.gnome.org/show_bug.cgi?id=306403

TEST PLAN
  1. "git clone kde:ark" and build the latest ark and unarchive my zip file
  2. It's totally unreadable like this
  
  (I use "7z l" to get the result, the highest priority plugin to handle zip mimetype)
  2016-03-21 10:38:56 .....        30208         8269  ¤½¶}¾\Äý¸ê®Æ¼t°Ó·N¨£ªí.doc
  2016-03-21 10:38:56 .....       306176        73434  «´¬ù±ø´Úªþ¥ó¤@_°]ª«³W®æ®Ñ.xls
  2016-03-21 10:38:56 .....        39424         9654  «´¬ù±ø´Úªþ¥ó¤T_Å禬¬ö¿ýÀÉ.doc
  
  3. With the patch, it works well, including listing filenames,
  
  open libreoffice by clicking the filename listed in ark, and
  unarchive the whole zip file.
  (I use "lsar" to get the result which is wriiten in unarchiver plugin")
  (I'm not sure if those chinese characters could be handle well by the review tool)
  公開閱覽資料廠商意見表.doc
  契約條款附件一_財物規格書.xls
  契約條款附件三_驗收紀錄檔.doc

REPOSITORY
  rARK Ark

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D1428

AFFECTED FILES
  plugins/cliunarchiverplugin/CMakeLists.txt
  plugins/cliunarchiverplugin/kerfuffle_cliunarchiver.json

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: acelankao, Ark
Cc: kde-utils-devel, tctara


More information about the Kde-utils-devel mailing list