Review Request 125372: Assume that header encryption is not enabled by default

Elvis Angelaccio elvis.angelaccio at kdemail.net
Thu Sep 24 13:27:16 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125372/
-----------------------------------------------------------

(Updated Sept. 24, 2015, 1:27 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Utils, Raphael Kubo da Costa and Ragnar Thomsen.


Changes
-------

Submitted with commit b99086196be108dbc76c202bf78ef0e4b5ac8bee by Elvis Angelaccio to branch Applications/15.08.


Bugs: 351608
    http://bugs.kde.org/show_bug.cgi?id=351608


Repository: ark


Description
-------

The boolean member `ReadOnlyArchiveInterface::m_isHeaderEncryptionEnabled` was not initalized and was then only set if the user explictly checked the header-encryption checkbox (i.e. triggering `ArchiveModel::enabledHeaderEncryption()` from `Part::openFile()`). Due to this behavior, we can simply initialize this boolean to false.


Diffs
-----

  kerfuffle/archiveinterface.cpp 01c054768d8f1757ce7af4587d6474f8099ce255 

Diff: https://git.reviewboard.kde.org/r/125372/diff/


Testing
-------


Thanks,

Elvis Angelaccio

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20150924/c8396768/attachment.html>


More information about the Kde-utils-devel mailing list