Review Request 125372: Assume that header encryption is not enabled by default

[Ragnar Thomsen]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125372/#review85867
-----------------------------------------------------------

Ship it!


Ship It!


kerfuffle/archiveinterface.cpp (line 39)
<https://git.reviewboard.kde.org/r/125372/#comment59286>

    Could you move the two variable initializations to their own lines?


- Ragnar Thomsen


On Sept. 24, 2015, 3:02 p.m., Elvis Angelaccio wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125372/
> -----------------------------------------------------------
> 
> (Updated Sept. 24, 2015, 3:02 p.m.)
> 
> 
> Review request for KDE Utils, Raphael Kubo da Costa and Ragnar Thomsen.
> 
> 
> Bugs: 351608
>     http://bugs.kde.org/show_bug.cgi?id=351608
> 
> 
> Repository: ark
> 
> 
> Description
> -------
> 
> The boolean member `ReadOnlyArchiveInterface::m_isHeaderEncryptionEnabled` was not initalized and was then only set if the user explictly checked the header-encryption checkbox (i.e. triggering `ArchiveModel::enabledHeaderEncryption()` from `Part::openFile()`). Due to this behavior, we can simply initialize this boolean to false.
> 
> 
> Diffs
> -----
> 
>   kerfuffle/archiveinterface.cpp 01c054768d8f1757ce7af4587d6474f8099ce255 
> 
> Diff: https://git.reviewboard.kde.org/r/125372/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Elvis Angelaccio
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20150924/4c518b3b/attachment.html>