Review Request 124468: Add support for comments

[Ragnar Thomsen]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124468/
-----------------------------------------------------------

(Updated Oct. 26, 2015, 11:50 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Utils, KDE Usability, Elvis Angelaccio, and Raphael Kubo da Costa.


Changes
-------

Submitted with commit 3a22bbd5ecfe409023088aa3e71e3151cc442860 by Ragnar Thomsen to branch master.


Bugs: 328790
    http://bugs.kde.org/show_bug.cgi?id=328790


Repository: ark


Description
-------

Add support for reading comments in CLI-based plugins such as rar and zip. The comment is parsed from the output of ListJob. The comment is displayed below the file view in a read-only QPlainTextEdit with monospace font. A QSplitter is used so the user can resize the comment field.

Support is added to clirar, clizip and cli7z plugins. AFAIK the 7z-format doesn't support comments, but the cli7z-plugin supports reading comments in e.g. zip archives.


Diffs
-----

  kerfuffle/archive_kerfuffle.h 8b1da5b 
  kerfuffle/archive_kerfuffle.cpp eb7f387 
  kerfuffle/archiveinterface.h b9111d2 
  kerfuffle/archiveinterface.cpp c2e89ca 
  kerfuffle/cliinterface.h 342ed0a 
  part/part.h 391d160 
  part/part.cpp baf152c 
  plugins/cli7zplugin/cliplugin.h afe3794 
  plugins/cli7zplugin/cliplugin.cpp 88a39ba 
  plugins/clilhaplugin/cliplugin.cpp f82e6fa 
  plugins/clirarplugin/cliplugin.h c72fff5 
  plugins/clizipplugin/cliplugin.h bec70d1 
  plugins/clizipplugin/cliplugin.cpp b97e714 

Diff: https://git.reviewboard.kde.org/r/124468/diff/


Testing
-------

Tested opening zip and rar archives with comments. Tested zip archives using both clizip and cli7z plugins.


File Attachments
----------------

Comment field at default size
  https://git.reviewboard.kde.org/media/uploaded/files/2015/07/26/e1c8c85e-fbcc-42b0-b096-f6e00494e07c__support-comments-7.png
Comment field with expanded size
  https://git.reviewboard.kde.org/media/uploaded/files/2015/07/26/6cbac8a0-2687-4960-8c03-74717638fdd7__support-comments-6.png


Thanks,

Ragnar Thomsen

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20151026/9b529403/attachment.html>