<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/124468/">https://git.reviewboard.kde.org/r/124468/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as submitted.</h1>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Utils, KDE Usability, Elvis Angelaccio, and Raphael Kubo da Costa.</div>
<div>By Ragnar Thomsen.</div>
<p style="color: grey;"><i>Updated Oct. 26, 2015, 11:50 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Submitted with commit 3a22bbd5ecfe409023088aa3e71e3151cc442860 by Ragnar Thomsen to branch master.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=328790">328790</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
ark
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Add support for reading comments in CLI-based plugins such as rar and zip. The comment is parsed from the output of ListJob. The comment is displayed below the file view in a read-only QPlainTextEdit with monospace font. A QSplitter is used so the user can resize the comment field.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Support is added to clirar, clizip and cli7z plugins. AFAIK the 7z-format doesn't support comments, but the cli7z-plugin supports reading comments in e.g. zip archives.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Tested opening zip and rar archives with comments. Tested zip archives using both clizip and cli7z plugins.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kerfuffle/archive_kerfuffle.h <span style="color: grey">(8b1da5b)</span></li>
<li>kerfuffle/archive_kerfuffle.cpp <span style="color: grey">(eb7f387)</span></li>
<li>kerfuffle/archiveinterface.h <span style="color: grey">(b9111d2)</span></li>
<li>kerfuffle/archiveinterface.cpp <span style="color: grey">(c2e89ca)</span></li>
<li>kerfuffle/cliinterface.h <span style="color: grey">(342ed0a)</span></li>
<li>part/part.h <span style="color: grey">(391d160)</span></li>
<li>part/part.cpp <span style="color: grey">(baf152c)</span></li>
<li>plugins/cli7zplugin/cliplugin.h <span style="color: grey">(afe3794)</span></li>
<li>plugins/cli7zplugin/cliplugin.cpp <span style="color: grey">(88a39ba)</span></li>
<li>plugins/clilhaplugin/cliplugin.cpp <span style="color: grey">(f82e6fa)</span></li>
<li>plugins/clirarplugin/cliplugin.h <span style="color: grey">(c72fff5)</span></li>
<li>plugins/clizipplugin/cliplugin.h <span style="color: grey">(bec70d1)</span></li>
<li>plugins/clizipplugin/cliplugin.cpp <span style="color: grey">(b97e714)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/124468/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/07/26/e1c8c85e-fbcc-42b0-b096-f6e00494e07c__support-comments-7.png">Comment field at default size</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/07/26/6cbac8a0-2687-4960-8c03-74717638fdd7__support-comments-6.png">Comment field with expanded size</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>