[Differential] [Requested Changes To] D471: Improve error handling by libarchive plugin
elvisangelaccio (Elvis Angelaccio)
noreply at phabricator.kde.org
Tue Nov 17 18:49:59 UTC 2015
elvisangelaccio requested changes to this revision.
This revision now requires changes to proceed.
INLINE COMMENTS
kerfuffle/queries.cpp:240 This messagebox can be quite crowded, e.g http://imgur.com/sbvCKXm.
If the error message in `%2` is always going to show the full path of the entry (like it does in this screenshot), then the filename in `%1` could only show the entry name. If not, leave it like this...
kerfuffle/queries.cpp:242 To avoid confusion, better to use `entry` than `file` here, because this could be a directory.
kerfuffle/queries.h:43 Cleanup needed
REPOSITORY
rARK Ark
REVISION DETAIL
https://phabricator.kde.org/D471
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: rthomsen, elvisangelaccio
Cc: kde-utils-devel
More information about the Kde-utils-devel
mailing list