Review Request 126077: Port kfloppy away from using KDE3Support

Wolfgang Bauer wbauer at tmo.at
Tue Nov 17 13:39:12 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126077/
-----------------------------------------------------------

(Updated Nov. 17, 2015, 1:39 p.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Utils.


Changes
-------

Submitted with commit dd16fd84f22dfe4945234e3fbfddd22cb5073f0c by Wolfgang Bauer to branch Applications/15.12.


Repository: kfloppy


Description
-------

This replaces all usage of K3Process (used to run the external programs) with KProcess.
That's the first step in porting kfloppy to KF5.


Diffs
-----

  CMakeLists.txt 9c1e410 
  format.h 0d51aa0 
  format.cpp 20b6d32 

Diff: https://git.reviewboard.kde.org/r/126077/diff/


Testing
-------

It still builds fine.

I formatted a few floppy disks, the external programs were called, the floppy disks got formatted, and the progress bar worked too.

Error messages when the needed tools are not available or the device cannot be accessed showed up as well.


Thanks,

Wolfgang Bauer

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20151117/6b0a26db/attachment.html>


More information about the Kde-utils-devel mailing list