Review Request 126077: Port kfloppy away from using KDE3Support

Jeremy Whiting jpwhiting at kde.org
Mon Nov 16 21:10:10 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126077/#review88449
-----------------------------------------------------------

Ship it!


Ship It!

- Jeremy Whiting


On Nov. 15, 2015, 12:14 p.m., Wolfgang Bauer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126077/
> -----------------------------------------------------------
> 
> (Updated Nov. 15, 2015, 12:14 p.m.)
> 
> 
> Review request for KDE Utils.
> 
> 
> Repository: kfloppy
> 
> 
> Description
> -------
> 
> This replaces all usage of K3Process (used to run the external programs) with KProcess.
> That's the first step in porting kfloppy to KF5.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 9c1e410 
>   format.h 0d51aa0 
>   format.cpp 20b6d32 
> 
> Diff: https://git.reviewboard.kde.org/r/126077/diff/
> 
> 
> Testing
> -------
> 
> It still builds fine.
> 
> I formatted a few floppy disks, the external programs were called, the floppy disks got formatted, and the progress bar worked too.
> 
> Error messages when the needed tools are not available or the device cannot be accessed showed up as well.
> 
> 
> Thanks,
> 
> Wolfgang Bauer
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20151116/a371e78f/attachment.html>


More information about the Kde-utils-devel mailing list