Review Request 123771: [Ark] Port to QApplication, QCommandLineParser and KAboutMenu.

[Ragnar Thomsen]

> On May 13, 2015, 2:46 p.m., Laurent Montel wrote:
> > app/main.cpp, line 111
> > <https://git.reviewboard.kde.org/r/123771/diff/2/?file=368702#file368702line111>
> >
> >     I spoke about all line
> >     => setApplicationName/DisplayName/Domain/Version
> >     all is done by kaboutdata::setapplicationdata
> >     
> >     why did you remove it ???

Sorry, my mistake. Should be fixed in patch 4.


- Ragnar


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123771/#review80296
-----------------------------------------------------------


On May 13, 2015, 2:53 p.m., Ragnar Thomsen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123771/
> -----------------------------------------------------------
> 
> (Updated May 13, 2015, 2:53 p.m.)
> 
> 
> Review request for KDE Utils, Bhushan Shah, Lukáš Tinkl, Laurent Montel, and Raphael Kubo da Costa.
> 
> 
> Repository: ark
> 
> 
> Description
> -------
> 
> Started porting of main.cpp to ultimately remove dependency on KDELibs4Support.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 363a751 
>   app/CMakeLists.txt bfed07a 
>   app/main.cpp 0fa72a9 
>   app/org.kde.ark.desktop.cmake e9c5973 
> 
> Diff: https://git.reviewboard.kde.org/r/123771/diff/
> 
> 
> Testing
> -------
> 
> Tested by opening and extracting various archive types. Tested opening local and remote URLs from commandline.
> 
> 
> Thanks,
> 
> Ragnar Thomsen
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20150513/bb5471a3/attachment-0001.html>