Review Request 123771: [Ark] Port to QApplication, QCommandLineParser and KAboutMenu.

Ragnar Thomsen rthomsen6 at gmail.com
Wed May 13 12:53:10 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123771/
-----------------------------------------------------------

(Updated May 13, 2015, 2:53 p.m.)


Review request for KDE Utils, Bhushan Shah, Lukáš Tinkl, Laurent Montel, and Raphael Kubo da Costa.


Changes
-------

Removed DisplayName, OrganizationDomain and ApplicationVersion which are already set in the KAboutData.


Repository: ark


Description
-------

Started porting of main.cpp to ultimately remove dependency on KDELibs4Support.


Diffs (updated)
-----

  CMakeLists.txt 363a751 
  app/CMakeLists.txt bfed07a 
  app/main.cpp 0fa72a9 
  app/org.kde.ark.desktop.cmake e9c5973 

Diff: https://git.reviewboard.kde.org/r/123771/diff/


Testing
-------

Tested by opening and extracting various archive types. Tested opening local and remote URLs from commandline.


Thanks,

Ragnar Thomsen

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20150513/eeb26fe5/attachment.html>


More information about the Kde-utils-devel mailing list