Review Request 124403: Ark: port Kerfuffle tests

Raphael Kubo da Costa rakuco at FreeBSD.org
Mon Jul 20 17:32:06 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124403/#review82718
-----------------------------------------------------------

Ship it!


Thanks. I'm assuming you've run the tests and they're passing; if so, feel free to land.

- Raphael Kubo da Costa


On July 20, 2015, 12:45 p.m., Elvis Angelaccio wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124403/
> -----------------------------------------------------------
> 
> (Updated July 20, 2015, 12:45 p.m.)
> 
> 
> Review request for KDE Utils, Bhushan Shah, Laurent Montel, and Raphael Kubo da Costa.
> 
> 
> Repository: ark
> 
> 
> Description
> -------
> 
> Ported the Kerfuffle tests to KF5. The QJson library is no more needed, since Qt5 provides built-in JSON support.
> 
> 
> Diffs
> -----
> 
>   kerfuffle/CMakeLists.txt 8d118033571b447f6ce09140417f25abcf9d2f79 
>   kerfuffle/tests/CMakeLists.txt 49f67c90dd84e2e5ab219e46f8210fba563f9139 
>   kerfuffle/tests/archivetest.cpp d72e53fe71fabb4438d9dfedf1fb74056bceb7a2 
>   kerfuffle/tests/jobstest.cpp c37ec4f546eb8eecf8273de2e3f607b8415a07d7 
>   kerfuffle/tests/jsonarchiveinterface.h b5a1acc7f71d4ba6db61c8397f3781e512cfa842 
>   kerfuffle/tests/jsonarchiveinterface.cpp 8af302754a1a5236d9f228cd32eb5df4d2a36952 
>   kerfuffle/tests/jsonparser.h 7ab49d87d4679467eb58eedb63a60853caf051f0 
>   kerfuffle/tests/jsonparser.cpp e85a940e804199b74f57727953ced9f54f61d5d2 
> 
> Diff: https://git.reviewboard.kde.org/r/124403/diff/
> 
> 
> Testing
> -------
> 
> All the tests build and pass.
> 
> 
> Thanks,
> 
> Elvis Angelaccio
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20150720/ddb9cb70/attachment.html>


More information about the Kde-utils-devel mailing list