<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/124403/">https://git.reviewboard.kde.org/r/124403/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Thanks. I'm assuming you've run the tests and they're passing; if so, feel free to land.</p></pre>
<br />
<p>- Raphael Kubo da Costa</p>
<br />
<p>On July 20th, 2015, 12:45 p.m. EEST, Elvis Angelaccio wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Utils, Bhushan Shah, Laurent Montel, and Raphael Kubo da Costa.</div>
<div>By Elvis Angelaccio.</div>
<p style="color: grey;"><i>Updated July 20, 2015, 12:45 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
ark
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Ported the Kerfuffle tests to KF5. The QJson library is no more needed, since Qt5 provides built-in JSON support.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">All the tests build and pass.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kerfuffle/CMakeLists.txt <span style="color: grey">(8d118033571b447f6ce09140417f25abcf9d2f79)</span></li>
<li>kerfuffle/tests/CMakeLists.txt <span style="color: grey">(49f67c90dd84e2e5ab219e46f8210fba563f9139)</span></li>
<li>kerfuffle/tests/archivetest.cpp <span style="color: grey">(d72e53fe71fabb4438d9dfedf1fb74056bceb7a2)</span></li>
<li>kerfuffle/tests/jobstest.cpp <span style="color: grey">(c37ec4f546eb8eecf8273de2e3f607b8415a07d7)</span></li>
<li>kerfuffle/tests/jsonarchiveinterface.h <span style="color: grey">(b5a1acc7f71d4ba6db61c8397f3781e512cfa842)</span></li>
<li>kerfuffle/tests/jsonarchiveinterface.cpp <span style="color: grey">(8af302754a1a5236d9f228cd32eb5df4d2a36952)</span></li>
<li>kerfuffle/tests/jsonparser.h <span style="color: grey">(7ab49d87d4679467eb58eedb63a60853caf051f0)</span></li>
<li>kerfuffle/tests/jsonparser.cpp <span style="color: grey">(e85a940e804199b74f57727953ced9f54f61d5d2)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/124403/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>