Review Request 120204: Create password-protected archives with Ark

[Elvis Angelaccio]

> On Lug. 8, 2015, 11:24 a.m., Kai Uwe Broulik wrote:
> > File Attachment: passwd-dialog-4.png - passwd-dialog-4.png
> > <https://git.reviewboard.kde.org/r/120204/#fcomment410>
> >
> >     Why can/is this thing even checked if it is disabled and not supported?

The password checkbox can be checked only if the selected mime type allows archive encryption. However, consider the scenario when the user changes the mime filter while the password checkbox is already checked: the user might select a non-encryptable format (like TAR) and thus the whole widget is disabled. An alternative behaviour could be to hide that widget, uncheck and then disable the checkbox.


> On Lug. 8, 2015, 11:24 a.m., Kai Uwe Broulik wrote:
> > File Attachment: passwd-dialog-4.png - passwd-dialog-4.png
> > <https://git.reviewboard.kde.org/r/120204/#fcomment411>
> >
> >     Too technical, it shows the prettified mime type in the filter, so it should here, too.

You're right, I forgot to fix this. Thanks.


- Elvis


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120204/#review82222
-----------------------------------------------------------


On Lug. 8, 2015, 9:34 a.m., Elvis Angelaccio wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120204/
> -----------------------------------------------------------
> 
> (Updated Lug. 8, 2015, 9:34 a.m.)
> 
> 
> Review request for KDE Utils and Raphael Kubo da Costa.
> 
> 
> Bugs: 253694
>     http://bugs.kde.org/show_bug.cgi?id=253694
> 
> 
> Repository: ark
> 
> 
> Description
> -------
> 
> This patch allows the users to create password-protected archives using Ark. 
> The supported plugins are `zip`, `7z` and `rar`.
> The input fields for the passwords are displayed only when the relevent mime filters are selected in the `AddDialog` window.
> 
> 
> Diffs
> -----
> 
>   app/mainwindow.cpp 470b72d00d0544662f2c1f10dbc0638b99f993af 
>   kerfuffle/CMakeLists.txt f5c5a335ad7386932af5d4f282a8eb3d2b9925a8 
>   kerfuffle/adddialog.h 7a8da46930007520df5633c4790f7c10e9f505d2 
>   kerfuffle/adddialog.cpp 9bb0a6d78fc1a8a2b29dd32f04538bf7ba541163 
>   kerfuffle/adddialog.ui a1c595b89202b1f2b44dc4f9c2faf68f5f655eb1 
>   kerfuffle/addtoarchive.h 788512bbf99648e0cc277d2aa5d75531923207fd 
>   kerfuffle/addtoarchive.cpp 1fb0d4d3e1782d7086fa668ee669cd471cb6ed7b 
>   kerfuffle/archive_kerfuffle.h 515788f978c1d29146c25dcb57a9dad2d46371f7 
>   kerfuffle/archive_kerfuffle.cpp c2c5b18528def63405a8703475b1c592ca945973 
>   kerfuffle/archiveinterface.h 801318b7842d78a0de54700ffdb43a945f513fbf 
>   kerfuffle/archiveinterface.cpp 3319de074225ccf8cb0fe54ffadca5882cf29342 
>   kerfuffle/cliinterface.h b4d79ed2f3ffbbbe28f7087f1fbff36de5138f36 
>   kerfuffle/cliinterface.cpp eab1c6a3200543989fd501e4d54e3e0b06b48999 
>   kerfuffle/createdialog.h PRE-CREATION 
>   kerfuffle/createdialog.cpp PRE-CREATION 
>   kerfuffle/createdialog.ui PRE-CREATION 
>   kerfuffle/kerfufflePlugin.desktop 3999d24f414ede1bb377f47b8c7d46dc44459b7d 
>   part/archivemodel.h 7f8c527fc331778e0ec74dce047eba5c56507499 
>   part/archivemodel.cpp 278715c843945970965d7c48e8a19a6dbd067c09 
>   part/part.cpp ee7f75ff9acd8ea3c72aa5a400d713ffc6d1c7c4 
>   plugins/cli7zplugin/cliplugin.cpp 500f121de97ef395110658a6ca495298bc797b46 
>   plugins/cli7zplugin/kerfuffle_cli7z.desktop.cmake 29b355af72b02d767e099a6e7a61778a70ae4476 
>   plugins/clirarplugin/cliplugin.cpp f5f7b184cb9f7ee16efd74968f2e86dc83668b4d 
>   plugins/clirarplugin/kerfuffle_clirar.desktop.cmake 3091d9d384952fbe27a43049c66c2ee998017957 
>   plugins/clizipplugin/cliplugin.cpp 30908d916448a6996f6c82072e2182c62b6792f2 
>   plugins/clizipplugin/kerfuffle_clizip.desktop.cmake 32ceced7b913c4d4a0d2007b4b3ea7b4ec850e35 
> 
> Diff: https://git.reviewboard.kde.org/r/120204/diff/
> 
> 
> Testing
> -------
> 
> Create `.zip`, `.7z` and `.rar` archives using the Ark `AddDialog` dialog (right click on an entry in Dolphin -> Compress -> Compress to...).
> Those archives are created as expected and their entries are marked as *Password protected*.
> If the user clicks on those entries, the standard password dialog is prompted to the user.
> 
> 
> File Attachments
> ----------------
> 
> passwd-dialog-0.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/06/13/8a30505d-47ef-4cf2-ab03-f98fe1891a81__passwd-dialog-0.png
> passwd-dialog-1.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/06/13/18288fb9-c822-4e2a-a719-036d452fc39b__passwd-dialog-1.png
> passwd-dialog-2.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/06/13/146b3e01-29f6-4cdf-98fd-cc948484d6c0__passwd-dialog-2.png
> passwd-dialog-3.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/06/13/7852abea-de46-4e1a-bb4c-82efd73b4823__passwd-dialog-3.png
> passwd-dialog-4.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/06/13/de22c272-c11e-4121-92d1-47a8eaac1301__passwd-dialog-4.png
> show-password.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/06/13/2305d88d-7b3d-4f8c-9909-f71eb8cb85f6__show-password.png
> 
> 
> Thanks,
> 
> Elvis Angelaccio
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20150708/a9e1ecd9/attachment.html>