<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/120204/">https://git.reviewboard.kde.org/r/120204/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin: 1em 0 0 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On luglio 8th, 2015, 11:24 a.m. UTC, <b>Kai Uwe Broulik</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding: 0 0 0 1em;">
<br style="display: none;" />
<table bgcolor="#f0f0f0" cellpadding="5" cellspacing="5" style="border: 1px solid #c0c0c0; margin-bottom: 10px">
<tr>
<td>
<a href="https://git.reviewboard.kde.org/r/120204/file/2145/" style="color: black; font-weight: bold; font-size: 9pt;">passwd-dialog-4.png</a>
<p>passwd-dialog-4.png</p>
</td>
</tr>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Why can/is this thing even checked if it is disabled and not supported?</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The password checkbox can be checked only if the selected mime type allows archive encryption. However, consider the scenario when the user changes the mime filter while the password checkbox is already checked: the user might select a non-encryptable format (like TAR) and thus the whole widget is disabled. An alternative behaviour could be to hide that widget, uncheck and then disable the checkbox.</p></pre>
<br />
<blockquote style="margin: 1em 0 0 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On luglio 8th, 2015, 11:24 a.m. UTC, <b>Kai Uwe Broulik</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding: 0 0 0 1em;">
<br style="display: none;" />
<table bgcolor="#f0f0f0" cellpadding="5" cellspacing="5" style="border: 1px solid #c0c0c0; margin-bottom: 10px">
<tr>
<td>
<a href="https://git.reviewboard.kde.org/r/120204/file/2145/" style="color: black; font-weight: bold; font-size: 9pt;">passwd-dialog-4.png</a>
<p>passwd-dialog-4.png</p>
</td>
</tr>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Too technical, it shows the prettified mime type in the filter, so it should here, too.</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">You're right, I forgot to fix this. Thanks.</p></pre>
<br />
<p>- Elvis</p>
<br />
<p>On luglio 8th, 2015, 9:34 a.m. UTC, Elvis Angelaccio wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Utils and Raphael Kubo da Costa.</div>
<div>By Elvis Angelaccio.</div>
<p style="color: grey;"><i>Updated Lug. 8, 2015, 9:34 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=253694">253694</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
ark
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This patch allows the users to create password-protected archives using Ark.
The supported plugins are <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">zip</code>, <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">7z</code> and <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">rar</code>.
The input fields for the passwords are displayed only when the relevent mime filters are selected in the <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">AddDialog</code> window.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Create <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">.zip</code>, <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">.7z</code> and <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">.rar</code> archives using the Ark <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">AddDialog</code> dialog (right click on an entry in Dolphin -> Compress -> Compress to...).
Those archives are created as expected and their entries are marked as <em style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Password protected</em>.
If the user clicks on those entries, the standard password dialog is prompted to the user.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>app/mainwindow.cpp <span style="color: grey">(470b72d00d0544662f2c1f10dbc0638b99f993af)</span></li>
<li>kerfuffle/CMakeLists.txt <span style="color: grey">(f5c5a335ad7386932af5d4f282a8eb3d2b9925a8)</span></li>
<li>kerfuffle/adddialog.h <span style="color: grey">(7a8da46930007520df5633c4790f7c10e9f505d2)</span></li>
<li>kerfuffle/adddialog.cpp <span style="color: grey">(9bb0a6d78fc1a8a2b29dd32f04538bf7ba541163)</span></li>
<li>kerfuffle/adddialog.ui <span style="color: grey">(a1c595b89202b1f2b44dc4f9c2faf68f5f655eb1)</span></li>
<li>kerfuffle/addtoarchive.h <span style="color: grey">(788512bbf99648e0cc277d2aa5d75531923207fd)</span></li>
<li>kerfuffle/addtoarchive.cpp <span style="color: grey">(1fb0d4d3e1782d7086fa668ee669cd471cb6ed7b)</span></li>
<li>kerfuffle/archive_kerfuffle.h <span style="color: grey">(515788f978c1d29146c25dcb57a9dad2d46371f7)</span></li>
<li>kerfuffle/archive_kerfuffle.cpp <span style="color: grey">(c2c5b18528def63405a8703475b1c592ca945973)</span></li>
<li>kerfuffle/archiveinterface.h <span style="color: grey">(801318b7842d78a0de54700ffdb43a945f513fbf)</span></li>
<li>kerfuffle/archiveinterface.cpp <span style="color: grey">(3319de074225ccf8cb0fe54ffadca5882cf29342)</span></li>
<li>kerfuffle/cliinterface.h <span style="color: grey">(b4d79ed2f3ffbbbe28f7087f1fbff36de5138f36)</span></li>
<li>kerfuffle/cliinterface.cpp <span style="color: grey">(eab1c6a3200543989fd501e4d54e3e0b06b48999)</span></li>
<li>kerfuffle/createdialog.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>kerfuffle/createdialog.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>kerfuffle/createdialog.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>kerfuffle/kerfufflePlugin.desktop <span style="color: grey">(3999d24f414ede1bb377f47b8c7d46dc44459b7d)</span></li>
<li>part/archivemodel.h <span style="color: grey">(7f8c527fc331778e0ec74dce047eba5c56507499)</span></li>
<li>part/archivemodel.cpp <span style="color: grey">(278715c843945970965d7c48e8a19a6dbd067c09)</span></li>
<li>part/part.cpp <span style="color: grey">(ee7f75ff9acd8ea3c72aa5a400d713ffc6d1c7c4)</span></li>
<li>plugins/cli7zplugin/cliplugin.cpp <span style="color: grey">(500f121de97ef395110658a6ca495298bc797b46)</span></li>
<li>plugins/cli7zplugin/kerfuffle_cli7z.desktop.cmake <span style="color: grey">(29b355af72b02d767e099a6e7a61778a70ae4476)</span></li>
<li>plugins/clirarplugin/cliplugin.cpp <span style="color: grey">(f5f7b184cb9f7ee16efd74968f2e86dc83668b4d)</span></li>
<li>plugins/clirarplugin/kerfuffle_clirar.desktop.cmake <span style="color: grey">(3091d9d384952fbe27a43049c66c2ee998017957)</span></li>
<li>plugins/clizipplugin/cliplugin.cpp <span style="color: grey">(30908d916448a6996f6c82072e2182c62b6792f2)</span></li>
<li>plugins/clizipplugin/kerfuffle_clizip.desktop.cmake <span style="color: grey">(32ceced7b913c4d4a0d2007b4b3ea7b4ec850e35)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/120204/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/06/13/8a30505d-47ef-4cf2-ab03-f98fe1891a81__passwd-dialog-0.png">passwd-dialog-0.png</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/06/13/18288fb9-c822-4e2a-a719-036d452fc39b__passwd-dialog-1.png">passwd-dialog-1.png</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/06/13/146b3e01-29f6-4cdf-98fd-cc948484d6c0__passwd-dialog-2.png">passwd-dialog-2.png</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/06/13/7852abea-de46-4e1a-bb4c-82efd73b4823__passwd-dialog-3.png">passwd-dialog-3.png</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/06/13/de22c272-c11e-4121-92d1-47a8eaac1301__passwd-dialog-4.png">passwd-dialog-4.png</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/06/13/2305d88d-7b3d-4f8c-9909-f71eb8cb85f6__show-password.png">show-password.png</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>