Review Request 126358: Fix ark not quiting problem.

[Xuetian Weng]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126358/
-----------------------------------------------------------

(Updated Dec. 15, 2015, 7:43 a.m.)


Status
------

This change has been marked as submitted.


Review request for KDE Utils and Elvis Angelaccio.


Changes
-------

Submitted with commit f7312a26d31cdc31776a09df600327ca86d3daea by Weng Xuetian to branch Applications/15.12.


Repository: ark


Description
-------

Previously, application.setQuitOnLastWindowClosed(false) is to fix https://bugs.kde.org/show_bug.cgi?id=181678 .

At that time, kmainwindow will reset it to true, so it will still work properly. This recently changed in kxmlgui 5.17 http://quickgit.kde.org/?p=kxmlgui.git&a=commit&h=155f524dd79add7d9d27f96f3c23e442133dc978 thus breaks ark.

This patch changes ark to only use setQuitOnLastWindowClosed(false) when a kjob is created and connect to quit() on finished signal.


Diffs
-----

  app/main.cpp 43c8352 

Diff: https://git.reviewboard.kde.org/r/126358/diff/


Testing
-------

Ark now exits when close main window, and bug 181678 is still not reproducible.


Thanks,

Xuetian Weng

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20151215/5baa3877/attachment.html>