Review Request 126358: Fix ark not quiting problem.

[Elvis Angelaccio]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126358/#review89518
-----------------------------------------------------------

Ship it!


Please ask the release-team whether it's still possible to respin the Ark 15.12 tarball, to include this commit.

- Elvis Angelaccio


On Dec. 15, 2015, 7 a.m., Xuetian Weng wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126358/
> -----------------------------------------------------------
> 
> (Updated Dec. 15, 2015, 7 a.m.)
> 
> 
> Review request for KDE Utils and Elvis Angelaccio.
> 
> 
> Repository: ark
> 
> 
> Description
> -------
> 
> Previously, application.setQuitOnLastWindowClosed(false) is to fix https://bugs.kde.org/show_bug.cgi?id=181678 .
> 
> At that time, kmainwindow will reset it to true, so it will still work properly. This recently changed in kxmlgui 5.17 http://quickgit.kde.org/?p=kxmlgui.git&a=commit&h=155f524dd79add7d9d27f96f3c23e442133dc978 thus breaks ark.
> 
> This patch changes ark to only use setQuitOnLastWindowClosed(false) when a kjob is created and connect to quit() on finished signal.
> 
> 
> Diffs
> -----
> 
>   app/main.cpp 43c8352 
> 
> Diff: https://git.reviewboard.kde.org/r/126358/diff/
> 
> 
> Testing
> -------
> 
> Ark now exits when close main window, and bug 181678 is still not reproducible.
> 
> 
> Thanks,
> 
> Xuetian Weng
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20151215/972956d4/attachment.html>