Review Request 116890: Patch for "Bug 279861 - When packing multiple selected files - use containing folder name "

[Florian Schunk]

> On April 21, 2014, 10 nachm., Raphael Kubo da Costa wrote:
> > kerfuffle/addtoarchive.cpp, line 155
> > <https://git.reviewboard.kde.org/r/116890/diff/1/?file=255272#file255272line155>
> >
> >     Please start the comment with a capital letter and end it with a period.

Where is stated, that comments should look like that? I couldn't find it in the documentation and the next comment in the file after my changes doesn't start with a cappital letter and doesn't end with a period.


- Florian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116890/#review56147
-----------------------------------------------------------


On Sept. 17, 2014, 7:50 nachm., Florian Schunk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116890/
> -----------------------------------------------------------
> 
> (Updated Sept. 17, 2014, 7:50 nachm.)
> 
> 
> Review request for KDE Utils.
> 
> 
> Bugs: 279861
>     http://bugs.kde.org/show_bug.cgi?id=279861
> 
> 
> Repository: ark
> 
> 
> Description
> -------
> 
> When in a folder i select multiple files to pack [Context Menu -> Compress -> As ZIP Archive] Ark automatically names the archive by first selected file. WinRAR uses in such cases name of the containing folder.
> 
> 
> Diffs
> -----
> 
>   kerfuffle/addtoarchive.cpp d13e095 
> 
> Diff: https://git.reviewboard.kde.org/r/116890/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Florian Schunk
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20140917/7d062611/attachment.html>