Review Request 116890: Patch for "Bug 279861 - When packing multiple selected files - use containing folder name "

Florian Schunk florian.schunk at rwth-aachen.de
Wed Sep 17 19:50:36 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116890/
-----------------------------------------------------------

(Updated Sept. 17, 2014, 7:50 nachm.)


Review request for KDE Utils.


Changes
-------

Ok I developed a new logic, to get the corner cases: The name is now the most-down folder in the file-tree, that all added files share. If its root, the name is the number of packed objects + "_Files". I also implemented your stylistic advices. I hope it is good now. Sorry for taking so long to update.


Bugs: 279861
    http://bugs.kde.org/show_bug.cgi?id=279861


Repository: ark


Description (updated)
-------

When in a folder i select multiple files to pack [Context Menu -> Compress -> As ZIP Archive] Ark automatically names the archive by first selected file. WinRAR uses in such cases name of the containing folder.


Diffs (updated)
-----

  kerfuffle/addtoarchive.cpp d13e095 

Diff: https://git.reviewboard.kde.org/r/116890/diff/


Testing
-------


Thanks,

Florian Schunk

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-utils-devel/attachments/20140917/d9f160e6/attachment.html>


More information about the Kde-utils-devel mailing list